Use Imagick methods instead of mogrify() for repo theme images - #2375
Merged
Conversation
sbreker
force-pushed
the
dev/repo-logo-use-imagick
branch
3 times, most recently
from
June 27, 2026 01:28
8dc8e44 to
3869a0a
Compare
anvit
reviewed
Jul 10, 2026
Comment on lines
+97
to
+100
| protected function shouldCropImages() | ||
| { | ||
| return extension_loaded('imagick'); | ||
| } |
Contributor
There was a problem hiding this comment.
Instead of defining this method, could we just re-use QubitDigitalObject::imagickExtensionLoaded since that is a static method?
Member
Author
There was a problem hiding this comment.
Good idea - I have updated this to use the static method 👍
sbreker
force-pushed
the
dev/repo-logo-use-imagick
branch
from
July 16, 2026 22:28
3869a0a to
333640d
Compare
anvit
approved these changes
Aug 12, 2026
Refactored class arRepositoryThemeCropValidatedFile to use Imagick methods instead of mogrify() command.
Replace the previous crop-only behavior with resize-and-crop processing for repository logo and banner uploads. Images are now scaled to cover the target dimensions while preserving aspect ratio, then center-cropped to the final logo or banner size. This keeps uploaded assets small after processing and avoids squashing non-square source images. Also increased the allowed upload size from 256K to 500K to give users more room to upload larger source images before resize and crop. Set Imagick memory, map, and pixel-area limits before reading repository logo and banner uploads.
sbreker
force-pushed
the
dev/repo-logo-use-imagick
branch
from
August 12, 2026 23:16
a484528 to
8b09994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored class arRepositoryThemeCropValidatedFile to use Imagick methods instead of mogrify command.
Replace the previous crop-only behavior with resize-and-crop processing for repository logo and banner uploads. Images are now scaled to cover the target dimensions while preserving aspect ratio, then center-cropped to the final logo or banner size. This keeps uploaded assets small after processing and avoids squashing non-square source images. Also increased the allowed upload size from 256K to 500K to give users more room to upload larger source images before resize and crop.
Set Imagick memory, map, and pixel-area limits before reading repository logo and banner uploads.